-
Notifications
You must be signed in to change notification settings - Fork 3
Feat/use rust for datacollect #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gaurav
wants to merge
29
commits into
NCATSTranslator:master
Choose a base branch
from
jdr0887:feat/use-rust-for-datacollect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat/use rust for datacollect #588
gaurav
wants to merge
29
commits into
NCATSTranslator:master
from
jdr0887:feat/use-rust-for-datacollect
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
commented
Oct 20, 2025
| # https://www.alliancegenome.org/downloads#gene-descriptions | ||
| # https://download.alliancegenome.org/8.1.0/GENE-DESCRIPTION-JSON/SGD/GENE-DESCRIPTION-JSON_SGD_9.json.gz | ||
| # origname = pull_via_urllib('https://fms.alliancegenome.org/download/',f'GENE-DESCRIPTION-JSON_{mod}.json.gz',subpath=subp) | ||
| origname = pull_via_urllib(f'https://download.alliancegenome.org/8.1.0/GENE-DESCRIPTION-JSON/{mod}/',f'GENE-DESCRIPTION-JSON_{mod}_9.json.gz', subpath=subp) |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdr0887 The previous URL (https://fms.alliancegenome.org/...) still works for me and is referenced from https://www.alliancegenome.org/downloads#gene-descriptions, and I'm not sure why you added the _9 here. Is there something we need to change in Babel?
gaurav
added a commit
that referenced
this pull request
Oct 20, 2025
This PR upgrades [pyoxigraph v0.2.5 to v0.4.11](https://pyoxigraph.readthedocs.io/en/stable/migration.html#from-0-2-to-0-3), which requires the interface to be updated. It also replaces the dodgy/outdated [python-Levenshtein-wheels](https://pypi.org/project/python-Levenshtein-wheels/) with the up-to-date [python-Levenshtein](https://pypi.org/project/python-Levenshtein/). Adapted from PR #588.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.